Skip to content

Commit

Permalink
fix($app): make proper distibution
Browse files Browse the repository at this point in the history
major changes following Minko's brief guide
  • Loading branch information
Jason Hodges committed Apr 27, 2017
1 parent 8924ac6 commit 2b95fa0
Show file tree
Hide file tree
Showing 24 changed files with 146 additions and 81 deletions.
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,6 @@ jspm_packages
.node_repl_history

.idea
build
typings
dist
.vscode
3 changes: 2 additions & 1 deletion .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,5 @@ Thumbs.db
!*.d.ts

docs
src
src
*.ngfactory.ts
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
language: node_js
node_js: stable
cache:
directories:
- node_modules
Expand Down
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# ngx-gist [![Build Status](https://travis-ci.org/jasonhodges/ngx-gist.svg?branch=master)](https://travis-ci.org/jasonhodges/ngx-gist) [![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)
[![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http:https://commitizen.github.io/cz-cli/)
# ngx-gist [![Build Status](https://travis-ci.org/jasonhodges/ngx-gist.svg?branch=master)](https://travis-ci.org/jasonhodges/ngx-gist) [![semantic-release](https://img.shields.io/badge/%20%20%F0%9F%93%A6%F0%9F%9A%80-semantic--release-e10079.svg)](https://github.com/semantic-release/semantic-release)[![Commitizen friendly](https://img.shields.io/badge/commitizen-friendly-brightgreen.svg)](http:https://commitizen.github.io/cz-cli/)

Angular 4 Component for embedding a gist within an Angular site

Expand Down
1 change: 0 additions & 1 deletion index.d.ts

This file was deleted.

1 change: 0 additions & 1 deletion index.js

This file was deleted.

41 changes: 0 additions & 41 deletions lib/ngx-gist.component.js

This file was deleted.

1 change: 0 additions & 1 deletion lib/ngx-gist.component.js.map

This file was deleted.

1 change: 0 additions & 1 deletion lib/ngx-gist.component.d.ts → lib/ngx-gist.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@ import { ElementRef, AfterViewInit } from '@angular/core';
export declare class ngxGist implements AfterViewInit {
iframe: ElementRef;
gistId: any;
constructor();
ngAfterViewInit(): void;
}
3 changes: 2 additions & 1 deletion src/ngx-gist.component.js → lib/ngx-gist.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions lib/ngx-gist.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions lib/ngx-gist.module.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { ngxGist } from './ngx-gist';
export { ngxGist };
export declare class MainModule {
}
27 changes: 27 additions & 0 deletions lib/ngx-gist.module.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions lib/ngx-gist.module.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions lib/ngx-gist.module.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { NgModule } from '@angular/core';
import { CommonModule } from '@angular/common';

import { NgxGist } from './ngx-gist';

@NgModule({
imports: [CommonModule],
declarations: [NgxGist],
exports: [NgxGist]
})
export class NgxGistModule { }
4 changes: 1 addition & 3 deletions src/ngx-gist.component.ts → lib/ngx-gist.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@ import {Component, Input, ViewChild, ElementRef, AfterViewInit} from '@angular/c
styleUrls: []
})

export class ngxGist implements AfterViewInit {
export class NgxGist implements AfterViewInit {
@ViewChild('iframe') iframe:ElementRef;
@Input() gistId;

constructor() { }

ngAfterViewInit() {
this.iframe.nativeElement.id = 'gist-' + this.gistId;
let doc = this.iframe.nativeElement.contentDocument || this.iframe.nativeElement.contentElement.contentWindow;
Expand Down
42 changes: 28 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,19 @@
"name": "ngx-gist",
"version": "1.0.0",
"description": "Angular 4 Component for embedding a gist within an Angular site",
"main": "bundles/ngx-gist.umd.js",
"module": "index.js",
"main": "ngx-gist.bundle.js",
"jsnext:main": "ngx-gist.module.js",
"module": "mgx-gist.module.js",
"types": "ngx-gist.module.d.ts",
"scripts": {
"semantic-release": "semantic-release pre && npm publish && semantic-release post",
"prepublish": "tsc",
"commit": "npm run prepublish && git-cz",
"build": "rm -rf lib && tsc -p src"
"commit": "git-cz",
"build": "rimraf dist && tsc -p tsconfig-esm.json && rollup -c rollup.config.js dist/ngx-gist.module.js > dist/ngx-gist.bundle.js && cp package.json dist && ts-node tools/cleanup.ts && ngc && cp README.md dist"
},
"typings": "./index.d.ts",
"repository": {
"type": "git",
"url": "https://github.com/jasonhodges/ngx-gist.git"
"url": "git+https://github.com/jasonhodges/ngx-gist.git"
},
"keywords": [
"angular",
Expand All @@ -28,17 +29,30 @@
"url": "https://github.com/jasonhodges/ngx-gist/issues"
},
"homepage": "https://github.com/jasonhodges/ngx-gist",
"peerDependencies": {
"@angular/core": ">=4.0.0"
},
"devDependencies": {
"@angular/common": "^4.0.0",
"@angular/compiler": "^4.0.0",
"@angular/compiler-cli": "^4.0.0",
"@angular/core": "^4.0.0",
"@angular/platform-browser": "^4.0.0",
"@angular/platform-browser-dynamic": "^4.0.0",
"@angular/platform-server": "^4.0.0",
"@types/node": "^7.0.14",
"rimraf": "^2.6.1",
"cz-conventional-changelog": "^2.0.0",
"typescript": "^2.1.4",
"webpack": "^1.14.0",
"semantic-release": "^6.3.2"
},
"dependencies": {
"@angular/common": "^4.0.3",
"@angular/compiler": "^4.0.3",
"@angular/core": "^4.0.3",
"rollup": "^0.41.6",
"rollup-plugin-commonjs": "^8.0.2",
"rollup-plugin-node-resolve": "^3.0.0",
"rollup-plugin-uglify": "^1.0.2",
"rxjs": "^5.0.3",
"semantic-release": "^6.3.2",
"tslint": "^5.1.0",
"typescript": "^2.1.5",
"uglify-js": "^2.8.22",
"webpack": "^1.14.0",
"zone.js": "^0.8.9"
},
"config": {
Expand Down
16 changes: 16 additions & 0 deletions rollup.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
export default {
format: 'umd',
moduleName: 'ngx-gist',
external: [
'@angular/core',
'@angular/common'
],
onwarn: ( warning ) => {
const skip_codes = [
'THIS_IS_UNDEFINED',
'MISSING_GLOBAL_NAME'
];
if ( skip_codes.indexOf(warning.code) != -1 ) return;
console.error(warning);
}
};
1 change: 0 additions & 1 deletion src/ngx-gist.component.js.map

This file was deleted.

8 changes: 8 additions & 0 deletions tools/cleanup.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tools/cleanup.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions tools/cleanup.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import { writeFileSync, readFileSync } from 'fs';

const packageJson = JSON.parse(readFileSync('./dist/package.json').toString());
delete packageJson.devDependencies;
delete packageJson.scripts;
writeFileSync('./dist/package.json', JSON.stringify(packageJson, null, 2));
20 changes: 7 additions & 13 deletions src/tsconfig.json → tsconfig-esm.json
Original file line number Diff line number Diff line change
@@ -1,23 +1,17 @@
{
"compilerOptions": {
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"target": "es5",
"module": "es2015",
"moduleResolution": "node",
"removeComments": true,
"sourceMap": true,
"outDir": "../lib",
"moduleResolution": "node",
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"stripInternal": true,
"declaration": true,
"outDir": "./dist",
"lib": ["es2015", "dom"]
},
"files": [
"../src/ngx-gist.component.ts"
],
"exclude": [
"node_modules"
],
"angularCompilerOptions": {
"skipTemplateCodegen": true
}
"./lib/ngx-gist.module.ts"
]
}
26 changes: 26 additions & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{
"compilerOptions": {
"target": "es5",
"module": "commonjs",
"sourceMap": true,
"emitDecoratorMetadata": true,
"experimentalDecorators": true,
"stripInternal": true,
"declaration": true,
"outDir": "./dist",
"lib": ["es2015", "dom"],
"typeRoots": [
"./node_modules/@types",
"./node_modules"
],
"types": [
"node"
]
},
"files": [
"./lib/ngx-gist.module.ts"
],
"angularCompilerOptions": {
"skipTemplateCodegen": true
}
}

0 comments on commit 2b95fa0

Please sign in to comment.