Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various stylistic changes #1

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Conversation

cxrodgers
Copy link

I just made some changes that I think improve readability. Feel free to take whatever suggestions you like (if any) and discard the rest.

One typo though: you have "Here are is a comparison" at one point.

@cxrodgers
Copy link
Author

Also, I wasn't sure what "easy to interpret due to their point-wise non-linearities" means. It seems a bit jargony. Does it just mean that the predictors are combined linearly before going through a single nonlinearity at the output? I might recommend phrasing it that way (if that's actually true). I didn't feel comfortable changing that part since I wasn't sure I understood it.

@cxrodgers cxrodgers mentioned this pull request Nov 4, 2019
21 tasks
@codecov-io
Copy link

codecov-io commented Nov 4, 2019

Codecov Report

Merging #1 into paper will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            paper       #1   +/-   ##
=======================================
  Coverage   75.66%   75.66%           
=======================================
  Files           4        4           
  Lines         678      678           
  Branches      149      149           
=======================================
  Hits          513      513           
  Misses        128      128           
  Partials       37       37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 515d241...005c176. Read the comment docs.

@jasmainak jasmainak merged commit a68db50 into jasmainak:paper Nov 4, 2019
@jasmainak
Copy link
Owner

Thanks @cxrodgers !

@jasmainak
Copy link
Owner

It seems a bit jargony. Does it just mean that the predictors are combined linearly before going through a single nonlinearity at the output?

@pavanramkumar perhaps you can do a pass over this part? I basically cut-pasted what was in the README already

jasmainak pushed a commit that referenced this pull request Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants