Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: code #1807

Merged
merged 11 commits into from
Jun 20, 2023
Merged

refactor: code #1807

merged 11 commits into from
Jun 20, 2023

Conversation

alexander-akait
Copy link
Collaborator

@alexander-akait alexander-akait commented Jun 19, 2023

Here:

  • simplify logic
  • avoid overhead Promise.resolve() (not eveywhere, we need improve it more)
  • reduce complexy
  • types fixes
  • TODO for the next major release
  • avoid extra clonning and other unnecessary overhead
  • and more

It is the first part of refactor, we need:

  • avoid using Promise.resolve()/etc in favor async/await
  • remove CacheChildCompiler in favor built-in webpack cache (compat with current behaviour, at the end this option will do nothing and just will be removed)
  • autogeneration types from jsdocs
  • readable code and simple code

@alexander-akait alexander-akait merged commit 8dafd5c into main Jun 20, 2023
18 checks passed
@alexander-akait alexander-akait deleted the refactor-code branch June 20, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant