Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frame_id exceeds the limit (0xff) #49

Merged
merged 1 commit into from
Oct 31, 2016
Merged

frame_id exceeds the limit (0xff) #49

merged 1 commit into from
Oct 31, 2016

Conversation

tibeoh
Copy link
Contributor

@tibeoh tibeoh commented Oct 31, 2016

If the frame_id is 0xff next frame id should be 1.

@jankolkmeier
Copy link
Owner

Good catch! Did this actually cause you trouble?

@tibeoh
Copy link
Contributor Author

tibeoh commented Oct 31, 2016

Yes because for each ZIGBEE_TRANSMIT_REQUESTframe sent I save it in an object with the id as key.
When I receive a response ZIGBEE_TRANSMIT_STATUS I remove it from the object and I can know if each frame is really received.
But with this issue, I send a frame with an id 256 and never receive response with this id.

@tibeoh tibeoh changed the title Update frame-builder.js frame_id exceeds the limit (0xff) Oct 31, 2016
@jankolkmeier jankolkmeier merged commit 79eebde into jankolkmeier:master Oct 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tibeoh @jankolkmeier