Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README to provide some help for Heroku users #19

Closed
wants to merge 1 commit into from
Closed

Update README to provide some help for Heroku users #19

wants to merge 1 commit into from

Conversation

SilaSpet
Copy link

The error mentioned in the changes happened to me. Took me a while to find the root cause of the problem since it only happened in production and the error message isn't that helpful. I think the changes in the README are pretty self-explanatory but if you have any questions I'd be happy to answer them.

@janko
Copy link
Owner

janko commented Nov 27, 2020

Thank you for the PR. I took it a step further and made rodauth-rails automatically pick up the secret key base from $SECRE_KEY_BASE in 47059bb. Could you test whether the current master branch works for you? Afterwards I'll release a new version 😉

@SilaSpet
Copy link
Author

I just removed my hmac_secret fix, deployed the current master to staging and added & authenticated via WebAuthn. Works perfectly! 🎉

@SilaSpet SilaSpet closed this Nov 27, 2020
@janko
Copy link
Owner

janko commented Nov 27, 2020

Great to hear! I've just released version 0.7.0 with this fix.

@SilaSpet SilaSpet deleted the patch-1 branch November 27, 2020 16:50
@SilaSpet
Copy link
Author

Updated and deployed to production 🚀 Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants