Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle long thread title without space #3107

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

urmauur
Copy link
Contributor

@urmauur urmauur commented Jun 26, 2024

Describe Your Changes

  1. Handle long thread titles without space
    Testing -> Try changing edit title with this aaaaabbbbccccddddeeeeffffgggg make sure ... ellipsis does not disappear and the setting menu is still accessible
Screenshot 2024-06-26 at 22 24 34
  1. Added auto focus on the search bar inside the model dropdown
Screenshot 2024-06-26 at 22 31 56

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Jun 26, 2024
@urmauur urmauur self-assigned this Jun 26, 2024
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@urmauur urmauur merged commit 0226c76 into dev Jun 27, 2024
7 checks passed
@urmauur urmauur deleted the fix/handle-long-thread-title branch June 27, 2024 02:45
@github-actions github-actions bot added this to the v.0.5.2 🍖 Kebap milestone Jun 27, 2024
namchuai pushed a commit that referenced this pull request Jul 12, 2024
* fix: handle long thread title without space, and make searchbar autofocus inside model dropdown

* feat: enable right click to show setting on thread items (#3108)
louis-jan pushed a commit that referenced this pull request Jul 12, 2024
* fix: handle long thread title without space, and make searchbar autofocus inside model dropdown

* feat: enable right click to show setting on thread items (#3108)
Van-QA added a commit that referenced this pull request Jul 15, 2024
* chore: upgrade marked-katex-extension (#3049)

* fix: handle long word without space to avoid right panel disappears (#3048)

* add time weighted retrieval (#2908)

* add time weighted retrieval

* add missing configuration for timeWeightedVectorStore

* resolving conflict

* add missing configuration for timeWeightedVectorStore

* resolving conflict

* fix linting issues

* fix build failed due to requirement for useTimeWeightedRetriever in AssistantTool

* update web packages complying the new structure

---------

Co-authored-by: thu <[email protected]>

* fix: model dropdown search by configured model (#3047)

* bump version (#3082) (#3083)

Co-authored-by: Hoang Ha <[email protected]>

* Update cortex cpp nightly to version 0.4.18 (#3072)

* Update cortex cpp nightly to version 0.4.17

* update linux downloadnitro

* c‌ortex 0.4.18

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Van Pham <[email protected]>

* chore: update download.ts (#3088)

infomation -> information

* chore: cortex version update (#3098)

* fix: handle words without space (#3101)

* fix: handle long thread title without space (#3107)

* fix: handle long thread title without space, and make searchbar autofocus inside model dropdown

* feat: enable right click to show setting on thread items (#3108)

* chore: Bump-cortex-0.4.17 (#3111)

* Update cortex cpp nightly to version 0.4.18 (#3114)

* Update cortex cpp nightly to version 0.4.18

* cortex 0.4.19

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Van Pham <[email protected]>

* Chore: Add stop token for Gemma 2b (#3125)

* add stop token

* Bump version

* fix: set specific version for terminate (#3126)

Signed-off-by: James <[email protected]>

* feat: add claude 3.5 sonnet (#3129)

Signed-off-by: James <[email protected]>

* feat: add options config spell check for chat input (#3131)

* fixed grammar nits (#3132)

* Update cortex cpp nightly to version 0.4.20

* fix: toggle button for expand log section on modal troubleshoot (#3130)

* fix: add tooltip messages toolbar (#3138)

* fix: handle error message when apikey is not setup (#3149)

* fix: title thread not updated on input edit title (#3148)

* merge dev

* fix move jan folder

* Update electron/preload.ts

* refactor

* Update electron/preload.ts

* fix wrong param

* use correct method

* chore: fix lint

---------

Signed-off-by: James <[email protected]>
Co-authored-by: Faisal Amir <[email protected]>
Co-authored-by: Nathan <[email protected]>
Co-authored-by: thu <[email protected]>
Co-authored-by: Van Pham <[email protected]>
Co-authored-by: Hoang Ha <[email protected]>
Co-authored-by: jan-service-account <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ikko Eltociear Ashimine <[email protected]>
Co-authored-by: NamH <[email protected]>
Co-authored-by: Saurabh <[email protected]>
Co-authored-by: Louis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants