Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loading jan browser #3011

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix: loading jan browser #3011

merged 1 commit into from
Jun 10, 2024

Conversation

phoval
Copy link
Contributor

@phoval phoval commented Jun 8, 2024 •
edited

Describe Your Changes

Fix crash loading jan in browser on docker
undefined, electron is not available

image

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@phoval
fix: undefined browser
4fadb16 
electron is not available
@namchuai
Copy link
Contributor

Thanks @phoval !

@Van-QA Van-QA added the type: chore Maintenance, integration, packaging related label Jun 10, 2024
@namchuai namchuai merged commit 57177d4 into janhq:dev Jun 10, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urmauur urmauur urmauur approved these changes

Assignees
No one assigned
Labels
type: chore Maintenance, integration, packaging related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@phoval @namchuai @urmauur @Van-QA