Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix crash when model name not ready #2931

Merged
merged 1 commit into from
May 21, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Fix crash when Hugging Face does not return model name. Tested with: crusoeai/Llama-3-8B-Instruct-262k-GGUF

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested review from Van-QA and louis-jan May 21, 2024 04:32
@github-actions github-actions bot added the type: bug Something isn't working label May 21, 2024
@namchuai namchuai force-pushed the fix/crash-when-model-name-not-available branch from f4ebb1d to 4623c1c Compare May 21, 2024 05:11
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA merged commit 6ba540d into dev May 21, 2024
7 checks passed
@Van-QA Van-QA deleted the fix/crash-when-model-name-not-available branch May 21, 2024 06:53
@github-actions github-actions bot added this to the v.0.5.0 🍵 Bubur Ayam milestone May 21, 2024
Van-QA added a commit that referenced this pull request May 27, 2024
* Fix: Phi-3 doesn't display (#2928)

* fix: params correction

* add phi

* version bump

* Feat/oai endpoints mapper using JSON (#2929)

* feat: test mapper

* chore: temporally add other runner

* chore: temp remove ubuntu-18-04-openai-api-collection-test

* chore: test json file

* chore: test json file

* Correct path endpoints_mapping.json

* feat: running via endpoints

* feat: running multiple endpoint

* feat: use endpoint value from workflow dispatch

* feat: add mapper between endpoint and python test file

* feat: config run all

* feat: config run all

---------

Co-authored-by: Van-QA <[email protected]>
Co-authored-by: Hien To <[email protected]>

* fix: fix crash when model name not ready (#2931)

Signed-off-by: James <[email protected]>
Co-authored-by: James <[email protected]>

* Replace deprecated steps github action (#2935)

Co-authored-by: Hien To <[email protected]>

* Chore: phi3 long-context update (#2936)

* init

* init

* fix: correct version

* version bump

* correct url

* remove small

* correct size

* Bump cortex to 0.4.8 (#2938)

* Update README.md (#2927)

Updated:

Title: Turn your computer into an AI computer
Nvidia -> NVIDIA
M1/M2 -> M1/M2/M3/M4

* docs: Update README.md (#2939)

* Bump cortex to 0.4.9 (#2940)

* Code sign retry 3 times (#2943)

* Replace deprecated steps github action

* Windows codesign retry 3 times

---------

Co-authored-by: Hien To <[email protected]>

* Chore: aya update (#2941)

* init

* init

* fix: correct format

* version bump

* add: aya 8b, aya 35b, phi3

* fix: stop token

* fix: stop token

* fix: unchange title and last message when clean or delete message (#2937)

* Update package.json to use [email protected] (#2949)

---------

Signed-off-by: James <[email protected]>
Co-authored-by: Hoang Ha <[email protected]>
Co-authored-by: Van-QA <[email protected]>
Co-authored-by: Hien To <[email protected]>
Co-authored-by: NamH <[email protected]>
Co-authored-by: James <[email protected]>
Co-authored-by: hiento09 <[email protected]>
Co-authored-by: eckartal <[email protected]>
Co-authored-by: Mohammed Aldakhil <[email protected]>
Co-authored-by: Faisal Amir <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants