Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cannot download phin34 model #2745

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: cannot download phin34 model #2745

merged 1 commit into from
Apr 17, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • User can't download phin34 model

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Apr 17, 2024
louis-jan
louis-jan approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-jan louis-jan merged commit a2cb135 into dev Apr 17, 2024
9 checks passed
@louis-jan louis-jan deleted the fix/cant-download-phin-34 branch April 17, 2024 11:36
@github-actions github-actions bot added this to the v0.4.12 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@Van-QA Van-QA Awaiting requested review from Van-QA

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@namchuai @louis-jan