Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct condition checking cuda dependencies windows #2629

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Correct condition checking cuda dependencies windows #2629

merged 1 commit into from
Apr 5, 2024

Conversation

hiento09
Copy link
Collaborator

@hiento09 hiento09 commented Apr 5, 2024

Describe Your Changes

Correct condition checking cuda dependencies windows

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@hiento09 hiento09 added the type: chore Maintenance, integration, packaging related label Apr 5, 2024
@hiento09 hiento09 added this to the v0.4.11 milestone Apr 5, 2024
@hiento09 hiento09 requested a review from a team April 5, 2024 09:05
@hiento09 hiento09 self-assigned this Apr 5, 2024
louis-jan
louis-jan approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hiento09 hiento09 merged commit b3c8bab into dev Apr 5, 2024
9 checks passed
@hiento09 hiento09 deleted the chore/correct-cuda-dependencies-checking branch April 5, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@hiento09 hiento09

Labels
type: chore Maintenance, integration, packaging related
Projects
Jan Project
Archived in project
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hiento09 @louis-jan @hientominh