Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API prefix settings #2528

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Add API prefix settings #2528

merged 2 commits into from
Apr 4, 2024

Conversation

GenkaOk
Copy link
Contributor

@GenkaOk GenkaOk commented Mar 28, 2024

Describe Your Changes

  • I added a new field to the server API settings
image image

You can change prefix for another clients.

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@Van-QA Van-QA requested review from louis-jan, urmauur and namchuai and removed request for urmauur March 29, 2024 02:14
louis-jan
louis-jan approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@louis-jan louis-jan force-pushed the patch-prefix branch 3 times, most recently from bb41443 to 2cdd9ac Compare April 3, 2024 15:21
@Van-QA Van-QA merged commit 089e311 into janhq:dev Apr 4, 2024
7 checks passed
@Van-QA Van-QA added this to the v0.4.11 milestone Apr 5, 2024
@Van-QA Van-QA mentioned this pull request Apr 5, 2024
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@namchuai namchuai Awaiting requested review from namchuai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.4.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GenkaOk @louis-jan @Van-QA