Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove files and memory when user clean thread #2524

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix: remove files and memory when user clean thread #2524

merged 1 commit into from
Mar 28, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Remove corresponding files and memory when user clean thread.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested a review from louis-jan March 28, 2024 06:25
@github-actions github-actions bot added the type: bug Something isn't working label Mar 28, 2024
louis-jan
louis-jan approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit 1f8dc89 into dev Mar 28, 2024
4 checks passed
@namchuai namchuai deleted the fix/2232 branch March 28, 2024 06:54
@github-actions github-actions bot added this to the v0.4.10 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
None yet
Milestone
v0.4.10
Development

Successfully merging this pull request may close these issues.
2 participants
@namchuai @louis-jan