Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only allow 4 stop words for openai #2457

Merged
merged 1 commit into from
Mar 22, 2024
Merged

fix: only allow 4 stop words for openai #2457

merged 1 commit into from
Mar 22, 2024

Conversation

namchuai
Copy link
Contributor

Describe Your Changes

  • Trim the stop words to maximum 4 words.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@namchuai namchuai requested a review from louis-jan March 22, 2024 05:56
@github-actions github-actions bot added the type: bug Something isn't working label Mar 22, 2024
louis-jan
louis-jan approved these changes Mar 22, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@namchuai namchuai merged commit 8303f74 into dev Mar 22, 2024
6 checks passed
@namchuai namchuai deleted the fix/2207 branch March 22, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

Assignees

@namchuai namchuai

Labels
type: bug Something isn't working
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@namchuai @louis-jan