Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: line height typography blog and docs #2390

Merged
merged 4 commits into from
Mar 16, 2024
Merged

fix: line height typography blog and docs #2390

merged 4 commits into from
Mar 16, 2024

Conversation

urmauur
Copy link
Contributor

@urmauur urmauur commented Mar 15, 2024

Describe Your Changes

Screenshot 2024-03-15 at 22 37 15
Screenshot 2024-03-15 at 22 36 52

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: bug Something isn't working label Mar 15, 2024
@urmauur urmauur self-assigned this Mar 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 15, 2024 •
edited
Loading

Preview URL: https://de8804b3.jan-qn8.pages.dev

@dan-jan
Copy link
Contributor

dan-jan commented Mar 15, 2024 •
edited
Loading

@urmauur Thanks for the quick turnaround. I can verify that the following were fixed:

  • List formatting has been restored (i.e. numbers, bullets, etc)
  • List paragraphing and line height is restored

One outstanding issue is the line heights of normal p text.

  • Line height is 2, which is not correct (I've never seen this before)
  • We should reduce line height to Docusaurus default
  • I think most p line height is 1.45-1.58, thereabouts? Not sure = you should see what industry standard is
  • This problem exists in both Docs as well as Blog

image

image

henryh0x1
henryh0x1 approved these changes Mar 16, 2024
View reviewed changes
Copy link
Collaborator

@henryh0x1 henryh0x1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@urmauur urmauur merged commit 82a751b into dev Mar 16, 2024
1 check passed
@urmauur urmauur deleted the fix/line-height branch March 16, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-jan dan-jan dan-jan approved these changes

@henryh0x1 henryh0x1 henryh0x1 approved these changes

@0xSage 0xSage Awaiting requested review from 0xSage

Assignees

@urmauur urmauur

Labels
type: bug Something isn't working
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@urmauur @dan-jan @henryh0x1