Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: existing changelog #2330

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix: existing changelog #2330

merged 1 commit into from
Mar 12, 2024

Conversation

henryh0x1
Copy link
Contributor

@henryh0x1 henryh0x1 commented Mar 12, 2024 •
edited
Loading

Describe Your Changes

  • Current fetchData still re-fetch the changelog running the docs. It's inconvenient when contributors running the docs. It re-fetch the changelog with same contents and display on Git changes. Thus, we only fetch the new changelog if not exists only

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@henryh0x1 henryh0x1 changed the title fix: existing-changelog fix: existing changelog Mar 12, 2024
@github-actions github-actions bot added the type: bug Something isn't working label Mar 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

Preview URL: https://8e3b2c11.jan-qn8.pages.dev

@henryh0x1 henryh0x1 merged commit 0747c15 into dev Mar 12, 2024
3 checks passed
@henryh0x1 henryh0x1 deleted the fix/existing-changelog branch March 12, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urmauur urmauur urmauur approved these changes

@aindrajaya aindrajaya Awaiting requested review from aindrajaya

Assignees

@henryh0x1 henryh0x1

Labels
type: bug Something isn't working
Projects
Jan & cortex.cpp
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryh0x1 @urmauur