Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codesign script force sign #2291

Merged
merged 1 commit into from
Mar 11, 2024
Merged

codesign script force sign #2291

merged 1 commit into from
Mar 11, 2024

Conversation

hiento09
Copy link
Collaborator

Describe Your Changes

  • codesign script force sign with new cert

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@hiento09 hiento09 added the type: bug Something isn't working label Mar 11, 2024
@hiento09 hiento09 added this to the v0.4.8 milestone Mar 11, 2024
@hiento09 hiento09 self-assigned this Mar 11, 2024
Van-QA
Van-QA approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@Van-QA Van-QA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiento09 hiento09 merged commit 3aeb643 into main Mar 11, 2024
9 of 12 checks passed
@hiento09 hiento09 deleted the regression/codesign-macos-force-sign branch March 11, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Van-QA Van-QA Van-QA approved these changes

@louis-jan louis-jan Awaiting requested review from louis-jan

Assignees

@hiento09 hiento09

Labels
type: bug Something isn't working
Projects
Jan Project
Archived in project
Milestone
v0.4.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hiento09 @Van-QA @hientominh