Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import from HuggingFace with random string is causing app crash #2214

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

louis-jan
Copy link
Contributor

Describe Your Changes

Even the input box specified that users should input following the format 'username/model-name,' but there are still cases where users input weird text such as random strings or full HuggingFace URLs.

Screenshot 2024-03-03 at 14 16 55

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Mar 3, 2024
@louis-jan louis-jan merged commit 1bdf791 into dev Mar 3, 2024
5 of 9 checks passed
@louis-jan louis-jan deleted the fix/import-huggingface-crash-app branch March 3, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants