Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update acknowledgements #2147

Merged
merged 9 commits into from
Feb 26, 2024
Merged

docs: update acknowledgements #2147

merged 9 commits into from
Feb 26, 2024

Conversation

henryh0x1
Copy link
Collaborator

Describe Your Changes

  • Add TensorRT license to Acknowledgements page
  • Update acknowledgement section in README.md

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Feb 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 25, 2024 •
edited
Loading

Preview URL: https://4c08aa80.jan-qn8.pages.dev

0xSage
0xSage requested changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@0xSage 0xSage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 requests:

  1. Move this page out of /engineering and under "How We Work"
  2. Rather than pasting in the entire licenses, can we just link out to their Licenses

0xSage
0xSage approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@0xSage 0xSage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@henryh0x1 henryh0x1 merged commit 92edd85 into dev Feb 26, 2024
1 check passed
@henryh0x1 henryh0x1 deleted the docs-update-acknowledgements branch February 26, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xSage 0xSage 0xSage approved these changes

@aindrajaya aindrajaya Awaiting requested review from aindrajaya

@Van-QA Van-QA Awaiting requested review from Van-QA

@cahyosubroto cahyosubroto Awaiting requested review from cahyosubroto

Assignees

@henryh0x1 henryh0x1

Labels
type: documentation Improvements or additions to documentation
Projects
Jan Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henryh0x1 @0xSage