Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: should stop running the model when GPU settings are changed #2067

Merged
merged 1 commit into from
Feb 18, 2024
Merged

fix: should stop running the model when GPU settings are changed #2067

merged 1 commit into from
Feb 18, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Feb 18, 2024 •
edited
Loading

Describe Your Changes

  • When GPU settings are toggled, the model should stop running as well

Fixes Issues

-Fixed #1906

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@github-actions github-actions bot added the type: bug Something isn't working label Feb 18, 2024
@louis-jan louis-jan merged commit 56034d6 into dev Feb 18, 2024
8 of 9 checks passed
@louis-jan louis-jan deleted the fix/change-gpu-settings-should-stop-active-model branch February 18, 2024 08:09
@louis-jan louis-jan added this to the v0.4.7 milestone Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namchuai namchuai namchuai approved these changes

@urmauur urmauur Awaiting requested review from urmauur

@hiento09 hiento09 Awaiting requested review from hiento09

Assignees

@louis-jan louis-jan

Labels
type: bug Something isn't working
Projects
Jan & cortex.cpp
Archived in project
Milestone
v0.4.7
Development

Successfully merging this pull request may close these issues.

bug: Toggle GPU accelerated On / Off should stop active model
2 participants
@louis-jan @namchuai