Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: model path backward compatible #2018

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Feb 14, 2024

Describe Your Changes:

  • This is to address the issue where old versions (less than 0.4.4) generate GGUF model file names as model.id. Recent updates will only look for GGUF filename. It now scans for the GGUF/Model ID binary file.
  • Also, support absolute model file paths (place it under ~/Downloads or somewhere else).

Scenario 1: Model file name the same as model id (<= 0.4.4)
Screenshot 2024-02-14 at 20 31 19

Scenario 2: Model file name is the same as downloaded GGUF file (<= 0.4.6)
Screenshot 2024-02-14 at 20 31 25

Scenario 3: Model binary can be anywhere
Screenshot 2024-02-14 at 21 12 04

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@louis-jan louis-jan force-pushed the fix/model-path-backward-compatible branch 2 times, most recently from 0182665 to 30c46ca Compare February 14, 2024 15:19
@louis-jan louis-jan force-pushed the fix/model-path-backward-compatible branch from 30c46ca to 6bc7413 Compare February 14, 2024 15:26
@louis-jan louis-jan merged commit f0fd2c5 into dev Feb 14, 2024
7 checks passed
@louis-jan louis-jan deleted the fix/model-path-backward-compatible branch February 14, 2024 16:04
@louis-jan louis-jan added this to the v0.4.7 milestone Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants