Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initialize POM structure with fixtures on Playwright #2015

Merged
merged 19 commits into from
Feb 15, 2024

Conversation

Van-QA
Copy link
Contributor

@Van-QA Van-QA commented Feb 14, 2024

Describe Your Changes

  • Video capturing on failures WIP
  • Sample page class with POM and fixtures

Fixes Issues

#1936
#2045

Self Checklist

image

@Van-QA Van-QA changed the title Auto/video on failures feat: Playwright capture video of Electron desktop app (Jan) on failures Feb 14, 2024
@Van-QA Van-QA marked this pull request as ready for review February 15, 2024 13:11
@Van-QA Van-QA changed the title feat: Playwright capture video of Electron desktop app (Jan) on failures feat: initialize POM structure on playwright Feb 15, 2024
@Van-QA Van-QA changed the title feat: initialize POM structure on playwright feat: Initialize POM structure with fixtures on Playwright Feb 15, 2024
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great refactoring, looks so clean!

@Van-QA Van-QA merged commit 82b361a into dev Feb 15, 2024
7 checks passed
@Van-QA Van-QA deleted the auto/video-on-failures branch February 15, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants