Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new model to the Hub #1213

Merged
merged 13 commits into from
Dec 29, 2023
Merged

Adding new model to the Hub #1213

merged 13 commits into from
Dec 29, 2023

Conversation

hahuyhoang411
Copy link
Contributor

@hahuyhoang411 hahuyhoang411 commented Dec 26, 2023

@hahuyhoang411 hahuyhoang411 added the P2: nice to have Nice to have feature label Dec 26, 2023
@hahuyhoang411 hahuyhoang411 self-assigned this Dec 26, 2023
@hahuyhoang411 hahuyhoang411 marked this pull request as draft December 26, 2023 10:27
@MrBenzWorld
Copy link

Thank you, all these models are great for code generations great.

@hahuyhoang411 hahuyhoang411 marked this pull request as ready for review December 26, 2023 14:30
@louis-jan
Copy link
Contributor

@hahuyhoang411 please help bump the model-extension version

"ctx_len": 4096,
"prompt_template": "GPT4 Correct User: {prompt}<|end_of_turn|>GPT4 Correct Assistant:"
},
"parameters": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going forward, you don't have to always set parameters and most of the properties. It should default to a global config in the future.

"object": "model",
"name": "CodeNinja 7B Q4",
"version": "1.0",
"description": "CodeNinja is an enhanced version of the renowned model openchat/openchat-3.5-1210. It is designed to be an indispensable tool for coders",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's be a bit more concise and pragmatic in our descriptions. No hyperbolic statements.

Just "description": "CodeNinja is finetuned on openchat/openchat-3.5-1210. Good for coding.",

Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hahuyhoang411 hahuyhoang411 merged commit b249639 into main Dec 29, 2023
@hahuyhoang411 hahuyhoang411 deleted the add/model-list branch December 29, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2: nice to have Nice to have feature
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants