fix: server crashes on missing module (#2089)

janhq · Feb 19, 2024 · e8f5c22 · e8f5c22
1 parent 780f957
commit e8f5c22
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/core/src/node/api/restful/helper/builder.ts b/core/src/node/api/restful/helper/builder.ts
@@ -318,13 +318,6 @@ export const chatCompletions = async (request: any, reply: any) => {
  apiUrl = engineConfiguration.full_url
  }
 
- reply.raw.writeHead(200, {
- 'Content-Type': 'text/event-stream',
- 'Cache-Control': 'no-cache',
- 'Connection': 'keep-alive',
- 'Access-Control-Allow-Origin': '*',
- })
-
  const headers: Record<string, any> = {
  'Content-Type': 'application/json',
  }
@@ -343,8 +336,14 @@ export const chatCompletions = async (request: any, reply: any) => {
  })
  if (response.status !== 200) {
  console.error(response)
- return
+ reply.code(400).send(response)
  } else {
+ reply.raw.writeHead(200, {
+ 'Content-Type': 'text/event-stream',
+ 'Cache-Control': 'no-cache',
+ 'Connection': 'keep-alive',
+ 'Access-Control-Allow-Origin': '*',
+ })
  response.body.pipe(reply.raw)
  }
 }
diff --git a/server/package.json b/server/package.json
@@ -27,19 +27,20 @@
  "@npmcli/arborist": "^7.3.1",
  "dotenv": "^16.3.1",
  "fastify": "^4.24.3",
- "request": "^2.88.2",
  "fetch-retry": "^5.0.6",
- "tcp-port-used": "^1.0.2",
- "request-progress": "^3.0.0"
+ "node-fetch": "2",
+ "request": "^2.88.2",
+ "request-progress": "^3.0.0",
+ "tcp-port-used": "^1.0.2"
  },
  "devDependencies": {
  "@types/body-parser": "^1.19.5",
  "@types/npmcli__arborist": "^5.6.4",
+ "@types/tcp-port-used": "^1.0.4",
  "@typescript-eslint/eslint-plugin": "^6.7.3",
  "@typescript-eslint/parser": "^6.7.3",
  "eslint-plugin-react": "^7.33.2",
  "run-script-os": "^1.1.6",
- "@types/tcp-port-used": "^1.0.4",
  "typescript": "^5.2.2"
  }
 }