Fix issue where repeater layer could be displayed incorrectly (airbnb…

…#2276)
janbildsoehansen · Jan 8, 2024 · 4f4b5a1 · 4f4b5a1
1 parent 9dc7d74
commit 4f4b5a1
Show file tree

Hide file tree

Showing 13 changed files with 3 additions and 3 deletions.
diff --git a/Sources/Private/CoreAnimation/Layers/ShapeLayer.swift b/Sources/Private/CoreAnimation/Layers/ShapeLayer.swift
@@ -187,7 +187,6 @@ extension CALayer {
  try setUpRepeater(
  repeater,
  items: repeaterGrouping.grouping,
- parentGroup: parentGroup,
  parentGroupPath: parentGroupPath,
  context: context)
  }
@@ -222,7 +221,6 @@ extension CALayer {
  private func setUpRepeater(
  _ repeater: Repeater,
  items allItems: [ShapeItemLayer.Item],
- parentGroup: Group?,
  parentGroupPath: [String],
  context: LayerContext)
  throws
@@ -233,7 +231,7 @@ extension CALayer {
  for index in 0..<copyCount {
  let groupLayers = try makeGroupLayers(
  from: items,
- parentGroup: parentGroup,
+ parentGroup: nil, // The repeater layer acts as the parent of its sublayers
  parentGroupPath: parentGroupPath,
  context: context)
 

diff --git a/Tests/Samples/Issues/issue_2270.json b/Tests/Samples/Issues/issue_2270.json
diff --git a/Tests/__Snapshots__/AutomaticEngineTests/testAutomaticEngineDetection.Issues-issue_2270.txt b/Tests/__Snapshots__/AutomaticEngineTests/testAutomaticEngineDetection.Issues-issue_2270.txt
@@ -0,0 +1 @@
+Supports Core Animation engine
diff --git a/...pshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2270-0.png b/...pshots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2270-0.png
diff --git a/...hots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2270-100.png b/...hots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2270-100.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2270-25.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2270-25.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2270-50.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2270-50.png
diff --git a/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2270-75.png b/...shots__/SnapshotTests/testCoreAnimationRenderingEngine.Issues-issue_2270-75.png
diff --git a/...Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2270-0.png b/...Snapshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2270-0.png
diff --git a/...apshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2270-100.png b/...apshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2270-100.png
diff --git a/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2270-25.png b/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2270-25.png
diff --git a/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2270-50.png b/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2270-50.png
diff --git a/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2270-75.png b/...napshots__/SnapshotTests/testMainThreadRenderingEngine.Issues-issue_2270-75.png