Add AIProxy support for certificate pinning #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzell
commented
Jun 26, 2024
| /// for: request, | ||
| /// delegate: mySession.delegate as? URLSessionTaskDelegate | ||
| /// ) | ||
| /// |
There was a problem hiding this comment.
@jamesrochabrun you will see I made the above changes to two places in the core of this lib. I tested both of them using the SwiftOpenAIExample app under the 'Default OpenAI Service' tab
lzell
commented
Jun 26, 2024
| let (data, response) = try await session.bytes( | ||
| for: request, | ||
| delegate: session.delegate as? URLSessionTaskDelegate | ||
| ) |
There was a problem hiding this comment.
Change to the core lib here
lzell
commented
Jun 26, 2024
| let (data, response) = try await session.bytes( | ||
| for: request, | ||
| delegate: session.delegate as? URLSessionTaskDelegate | ||
| ) |
There was a problem hiding this comment.
Change to the core lib here
jamesrochabrun
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requests to AIProxy only succeed if we recognize the public certificate used in establishing the tls handshake. This makes performing a MITM attack more challenging. MITM is a common tactic against mobile apps because the attacker controls the hardware. They can use desktop proxy software to MITM an app and decrypt the https requests as they go by (this requires installing a trusted certificate on the attacker's phone, which is also trivial).
This is one additional layer of security in our defense against API abuse.
The majority of this patch only impacts AIProxy-specific code, however there are two spots where a change was required to the core codebase. I will highlight each with a comment. For details about why they were changed (which I consider an Apple bug) please see the docstring on
AIProxyCertificatePinning.swift