Fix decoding error on assistants response #31
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
response_format
andtool_choice
fields of an assistant's run can either be objects or strings.Previously, if the
tool_choice
was a string (e.g. 'auto') in the run response, we failed to decode the response. Similarly, if theresponses_type
was a string (e.g. 'auto') in the run response, we failed to decode the response.This bug was reported by @mbrian23, with a full repro here. Thank you Martin!
https://gist.github.com/mbrian23/6863ffa705ccbb5097bd07efb2355a30
I added regression tests for the failing case.
References:
https://platform.openai.com/docs/api-reference/runs/createRun#runs-createrun-response_format
https://platform.openai.com/docs/api-reference/runs/createRun#runs-createrun-tool_choice