Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accepting null as the first param of the convertToLocal method. #19

Merged
merged 2 commits into from
Jan 28, 2020
Merged

Accepting null as the first param of the convertToLocal method. #19

merged 2 commits into from
Jan 28, 2020

Conversation

amandiobm
Copy link
Contributor

Accepting null as the first param of the convertToLocal method.

Amandio Magalhaes added 2 commits January 23, 2020 09:34
@jamesmills
Copy link
Owner

Why would the date/time ever be null?

@amandiobm
Copy link
Contributor Author

Have some use cases.

When using SoftDeletes trait, by default the column deleted_at is null. (Which is this that is breaking right now hehe )

I also have a list that contains three different dates, and all of them could be null as well. Once is null it will break the directive.

@jamesmills jamesmills mentioned this pull request Jan 28, 2020
Closed
@jamesmills jamesmills merged commit 3fa619c into jamesmills:master Jan 28, 2020
@amandiobm amandiobm deleted the hotfix-18 branch January 29, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amandiobm @jamesmills