Ability to provide a lookup table to fetch the remote address. #13
Conversation
|
Hi @amandiobm! Thank you for this suggested solution to the initial issue (#8) which @ridz1208 submitted. This solution is much more thorough than the one I was going to suggest so thank you for this and awsome work. I don't see anything that would need changing for it to be merged. Once you have updated the README I would be happy to merge, tag and push this to the world! Thank you. |
|
Neat. I still need to update the README, the config description, a double-check, and we're all good ;) It would be nice to hear from @ridz1208 if that approach would help him. See you soon, and is always a pleasure ;) |
|
I think we're all done @jamesmills . take a look. |
There was a problem hiding this comment.
Let me just start with THIS IS GREAT !!
Thank you @amandiobm and @jamesmills for working on this that quickly, I didn't even have a chance to dive into it.
As for the changes themselves. I think it would definitely work. If I understand correctly you can define a set of headers in which you expect to find the real IP and the code then reads through them and as soon as 1 IP is found it will automatically be used.
README.md
Outdated
| @@ -118,6 +118,10 @@ By default, the timezone will be overwritten at each login with the current user | |||
|
|
|||
| By default, the date format will be `jS F Y g:i:a`. To override this configuration, you just need to change the `format` property inside the configuration file `config/timezone.php` for the desired format. | |||
|
|
|||
| ### Lookup Array | |||
|
|
|||
| this lookup array configuration makes it possible to find the remote address of the user in any attribute inside the Laravel `request` helper, by any key. Having in mind when the key is found inside the attribute, that key will be used. By default, we use the `server` attribute with the key `REMOTE_ADDR`. To override this configuration, you just need to change the `lookup` property inside the configuration file `config/timezone.php` for the desired lookup. | |||
There was a problem hiding this comment.
This should start with an uppercase letter
There was a problem hiding this comment.
As for the changes themselves. I think it would definitely work. If I understand correctly you can define a set of headers in which you expect to find the real IP and the code then reads through them and as soon as 1 IP is found it will automatically be used.
I wouldn't say 1st IP. It will search for the key inside the attribute. Once it's found, it will be used.
Maybe we are talking about the same thing using different wording hehe.
|
Hey @jamesmills any follow-up? |
|
Hi! Looks great, I will look at the PR when I am in the office tomorrow and update the changelog and tag a new release. Thank you for your continued support! James |
|
Done. Thanks again. |
Related to issue #8
@jamesmills & @ridz1208 I did some initial implementation on that issue, please take a look and feel free to add comments, commits, etc. ;)
I initially thought of creating a lookup table so we can search in whatever attribute inside the request helper, by any key. Having in mind when the key is found inside the attribute, that key will be used.