Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dispatching several actions ONCE. #6

Closed
wants to merge 2 commits into from

Conversation

CrOrc
Copy link

@CrOrc CrOrc commented Jul 29, 2017

Dispatching several actions once has problem. Every second sequential ONCE action is skipped.

Problem is described in accepted answer here.

Calling splice within forEach reenumerates array, so action with true condition will be skipped if it was added after ONCE action with true condition.

Fixes #7

@CrOrc CrOrc changed the title Fix dispatching several actions ONCE Fix dispatching several actions ONCE. Fixed #7 Jul 29, 2017
@CrOrc CrOrc changed the title Fix dispatching several actions ONCE. Fixed #7 Fix dispatching several actions ONCE. Fixes #7 Jul 29, 2017
@CrOrc CrOrc changed the title Fix dispatching several actions ONCE. Fixes #7 Fix dispatching several actions ONCE. Jul 29, 2017
@jameslnewell
Copy link
Owner

My sincere apologies for missing this PR! I've incorporated your test in 06bcf9d however delete didn't seem to work as intended.

This fix has been released in 2.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all actions may be dispatched
2 participants