once immediate evaluation and changes to array item removal #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| //dispatch the delayed action | ||
| store.dispatch(when.payload.createAction(action)); | ||
| const readyToBeDispatched = waiting |
There was a problem hiding this comment.
Was there any reason this section needed to change from a for loop?
There was a problem hiding this comment.
Hi James! Thanks for merging my pull request!
This was changed because of possible future issues occuring when trying to mutate the array while iterating over it...
There was a problem hiding this comment.
Ah! I changed it back because I thought the for loop was more readable and saved a few cpu cycles. If it is an issue with JS arrays please feel free to change it back!
|
Thanks! I've released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add immediate evaluation for WHEN and ONCE type actions.
changes to removal of array items, preventing future bugs when splicing array items while iterating over the array.