Missing addr flag for announcing core-lightning nodes externally #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The missing `--addr=0.0.0.0:9735` causes failure in connecting to core-lightning nodes externally. Polar in the connect tab shows P2P External for core-lightning nodes but it does not work because it's not being announced.
jamaljsr
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The missing
--addr=0.0.0.0:9735causes failure in connecting to core-lightning nodes externally. Polar in the connect tab shows P2P External for core-lightning nodes but it does not work because it's not being announced.Steps to Test
telnet localhost 9836without the announcing, connection succeeds but terminates instantly.You can also try testing using something like this library https://github.com/jb55/lnsocket/tree/master/examples and commando runes.