Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Binance API Deprecation [effective on Septembre 9th!] #491

Closed
waterdrop01 opened this issue Sep 7, 2020 · 1 comment · Fixed by #492
Closed

Binance API Deprecation [effective on Septembre 9th!] #491

waterdrop01 opened this issue Sep 7, 2020 · 1 comment · Fixed by #492
Labels
help wanted needs-solution

Comments

@waterdrop01
Copy link
Contributor

As per Binance API announcement, outboundAccountInfo data stream is now deprecated.
Screenshot from 2020-09-07 15-23-48

But looking at node-binance-api source code, the deprecated type is still in use, and the new type outboundAccountPosition is not used.
Screenshot from 2020-09-07 15-29-14

What is the recommended way to handle this API change? (effective in 2 days)

Thanks!
gunar added a commit to gunar/node-binance-api that referenced this issue Sep 8, 2020
@gunar
fix: deprecate outboundAccountInfo
6075392 
Fixes jaggedsoft#491

Ideally this would warrant a breaking change of the library
but since the new endpoint returns a subset that is consistent
with previous behavior, and understanding the risk assessment
of letting thousands of consumers of the library have their applications
be broken, it seems smart to pipe one stream into the other.
@gunar gunar mentioned this issue Sep 8, 2020
Merged
@gunar
Copy link
Contributor

gunar commented Dec 30, 2020

Reminder that we've deprecated outboundAccountInfo on 6075392. I've just received a new notification from Binance (on Telegram) that they'll deprecate it soon so it seems they're delaying the breaking change. Whenever it happens, our work is done already.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted needs-solution
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: deprecate outboundAccountInfo gunar/node-binance-api
3 participants
@jaggedsoft @gunar @waterdrop01