Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define http.Server.ErrorLog to forward logs to Zap #3157

Merged
merged 7 commits into from
Jul 22, 2021

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Jul 21, 2021

Related to #3156

@yurishkuro yurishkuro requested a review from a team as a code owner July 21, 2021 16:21
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #3157 (c4c7d8d) into master (605c1f1) will decrease coverage by 0.00%.
The diff coverage is 84.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
- Coverage   95.95%   95.94%   -0.01%     
==========================================
  Files         239      239              
  Lines       14624    14647      +23     
==========================================
+ Hits        14032    14053      +21     
- Misses        515      518       +3     
+ Partials       77       76       -1     
Impacted Files Coverage Δ
cmd/collector/app/server/zipkin.go 70.73% <0.00%> (-4.95%) ⬇️
cmd/query/app/server.go 95.58% <91.66%> (+1.61%) ⬆️
cmd/agent/app/builder.go 96.07% <100.00%> (ø)
cmd/agent/app/httpserver/srv.go 100.00% <100.00%> (ø)
cmd/collector/app/server/http.go 100.00% <100.00%> (ø)
cmd/flags/admin.go 82.81% <100.00%> (+1.45%) ⬆️
...lugin/sampling/strategystore/adaptive/processor.go 99.35% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 605c1f1...c4c7d8d. Read the comment docs.

Signed-off-by: Yuri Shkuro <[email protected]>
cmd/flags/admin.go Outdated Show resolved Hide resolved
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro changed the title [WIP] Set http.Server.ErrorLog to forward logs to Zap Define http.Server.ErrorLog to forward logs to Zap Jul 21, 2021
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro
Copy link
Member Author

codecov is lying about coverage change

@jpkrohling jpkrohling merged commit f8a6b3c into jaegertracing:master Jul 22, 2021
@yurishkuro yurishkuro deleted the fix-3156 branch July 22, 2021 14:30
@vprithvi vprithvi added this to the Release 1.25.0 milestone Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants