Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable test shuffle for more robust test suite #3349

Open
rbroggi opened this issue Oct 28, 2021 · 0 comments
Open

Enable test shuffle for more robust test suite #3349

rbroggi opened this issue Oct 28, 2021 · 0 comments

Comments

@rbroggi
Copy link
Contributor

rbroggi commented Oct 28, 2021

Requirement - what kind of business use case are you trying to solve?

Go 1.17 introduced the -shuffle flag to avoid deterministic test execution order. The goal of using -shuffle is to make sure that the test suite is stable and each test is well isolated from the other.

I suggest we introduce -shuffle in the test target
rbroggi added a commit to rbroggi/jaeger that referenced this issue Oct 28, 2021
@rbroggi
Issue jaegertracing#3349 - enable -shuffle=on in tests
b0a8b62
@rbroggi rbroggi mentioned this issue Oct 28, 2021
Closed
rbroggi added a commit to rbroggi/jaeger that referenced this issue Oct 28, 2021
@rbroggi
Issue jaegertracing#3349 - enable -shuffle=on in tests
7f57003 
Signed-off-by: rbroggi <[email protected]>
rbroggi added a commit to rbroggi/jaeger that referenced this issue Oct 30, 2021
@rbroggi
Issue jaegertracing#3349 - enable -shuffle=on in tests
e23af42 
Signed-off-by: rbroggi <[email protected]>
rbroggi added a commit to rbroggi/jaeger that referenced this issue Oct 31, 2021
@rbroggi
Issue jaegertracing#3349 - enable -shuffle=on in tests
222106e 
Signed-off-by: rbroggi <[email protected]>
rbroggi added a commit to rbroggi/jaeger that referenced this issue Oct 31, 2021
@rbroggi
Issue jaegertracing#3349 - enable -shuffle=on in tests
e8dfd26 
Signed-off-by: rbroggi <[email protected]>
yurishkuro pushed a commit that referenced this issue Oct 31, 2021
@rbroggi
[bugfix] Treat input throughput data as immutable (#3360)
514e72b 
* Issue #3349 - enable `-shuffle=on` in tests

Signed-off-by: rbroggi <[email protected]>

* fixing test interdependency due to shared global variable (which is written to)

Signed-off-by: rbroggi <[email protected]>

* fixing test interdependency due to shared global variable

Signed-off-by: rbroggi <[email protected]>

* enforcing method immutability

Signed-off-by: rbroggi <[email protected]>

* temporarily disable shuffle

Signed-off-by: rbroggi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #3349 - enable -shuffle=on in tests rbroggi/jaeger
1 participant
@rbroggi