-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unstable unit test on TraceStatistics/tableValues.tsx #877
Labels
Comments
yurishkuro
added a commit
that referenced
this issue
Oct 24, 2023
…ics view (#1901) ## Which problem is this PR solving? - Resolves #1592 & Resolves #1263 - Indirectly Resolves #877 ## Description of the changes - When calculating selfTime of a span - selfTime is the total time spent in the span when it was not waiting on children. - So we skip the `FOLLOWS_FROM` type child spans - selfTime = duration - (total time consumed by child spans between span startTime and endTime) - This is implemented by using `DRange` similar to the logic in TraceGraph @yurishkuro --------- Signed-off-by: GLVS Kiriti <[email protected]> Signed-off-by: GLVSKiriti <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Based on #876 CI run, the code coverage came up with a change, even though no source code changes were made.
There as places with coverage changes in packages/jaeger-ui/src/components/TracePage/TraceStatistics/tableValues.tsx:
The text was updated successfully, but these errors were encountered: