Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable unit test on TraceStatistics/tableValues.tsx #877

Closed
yurishkuro opened this issue Feb 4, 2022 · 0 comments · Fixed by #1901
Closed

Unstable unit test on TraceStatistics/tableValues.tsx #877

yurishkuro opened this issue Feb 4, 2022 · 0 comments · Fixed by #1901
Labels
bug

Comments

@yurishkuro
Copy link
Member

Based on #876 CI run, the code coverage came up with a change, even though no source code changes were made.

There as places with coverage changes in packages/jaeger-ui/src/components/TracePage/TraceStatistics/tableValues.tsx:

image
image
image
@yurishkuro yurishkuro added the bug label Feb 4, 2022
@yurishkuro yurishkuro changed the title Unstable unit test Unstable unit test on TraceStatistics/tableValues.tsx Feb 4, 2022
@GLVSKiriti GLVSKiriti mentioned this issue Oct 21, 2023
Merged
yurishkuro added a commit that referenced this issue Oct 24, 2023
@GLVSKiriti @yurishkuro
[Refactor]: Enhancement to selfTime calculation logic in TraceStatist…
614bfc9 
…ics view (#1901)

## Which problem is this PR solving?
- Resolves #1592  & Resolves #1263 
- Indirectly Resolves #877 

## Description of the changes
-  When calculating selfTime of a span  
- selfTime is the total time spent in the span when it was not waiting
on children.
  - So we skip the `FOLLOWS_FROM` type child spans 
- selfTime = duration - (total time consumed by child spans between span
startTime and endTime)
- This is implemented by using `DRange` similar to the logic in
TraceGraph
@yurishkuro

---------

Signed-off-by: GLVS Kiriti <[email protected]>
Signed-off-by: GLVSKiriti <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Refactor]: Enhancement to selfTime calculation logic in TraceStatistics view GLVSKiriti/jaeger-ui
1 participant
@yurishkuro