-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uploading files into Search page performs unnecessary POST #2192
Labels
Comments
@yurishkuro |
go for it |
4 tasks
yurishkuro
pushed a commit
that referenced
this issue
Mar 5, 2024
## Which problem is this PR solving? - Resolves #2192 ## Description of the changes - Remove uploading files into the search page unnecessary POST ## How was this change tested? Manually tested. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` Signed-off-by: tico88612 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To reproduce:
yarn start
POST http:https://localhost:5173/ 404 (Not Found)
The uploading files does not require communication with the server, it loads JSON in browser and displays the traces. However, somehow the way we're using
Upload
from AntDesign is causing it to submit the file back to the server from where the UI is loaded (normally it would be jaeger query service), which is neither necessary nor safe.The text was updated successfully, but these errors were encountered: