Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uploading files into Search page performs unnecessary POST #2192

Closed
yurishkuro opened this issue Mar 4, 2024 · 2 comments · Fixed by #2200
Closed

Uploading files into Search page performs unnecessary POST #2192

yurishkuro opened this issue Mar 4, 2024 · 2 comments · Fixed by #2200
Labels
good first issue help wanted

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Mar 4, 2024 •
edited
Loading

To reproduce:

  • run jaeger-all-in-one separately
  • yarn start
  • Refresh screen so that Services dropdown shows all-in-one, and find & load its trace
  • Export that trace to local JSON file
  • Click on Search | Upload
  • Open DevTools in Chrome
  • click on upload icon and select saved file
  • The console shows an error message POST http:https://localhost:5173/ 404 (Not Found)
  • The file name shows up in red and its tooltip shows an error message
  • Meanwhile the file is loaded normally and shown in search results
image

The uploading files does not require communication with the server, it loads JSON in browser and displays the traces. However, somehow the way we're using Upload from AntDesign is causing it to submit the file back to the server from where the UI is loaded (normally it would be jaeger query service), which is neither necessary nor safe.
@tico88612
Copy link
Contributor

@yurishkuro
I have a solution to resolve this issue. Can I work on this?

@yurishkuro
Copy link
Member Author

go for it

@tico88612 tico88612 mentioned this issue Mar 5, 2024
Merged
4 tasks
yurishkuro pushed a commit that referenced this issue Mar 5, 2024
@tico88612
Fix upload file into search page unnecessary POST (#2200)
8fe552a 
## Which problem is this PR solving?
- Resolves #2192

## Description of the changes
- Remove uploading files into the search page unnecessary POST

## How was this change tested?
Manually tested.

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

Signed-off-by: tico88612 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix upload file into search page unnecessary POST tico88612/jaeger-ui
2 participants
@yurishkuro @tico88612