[Bug]: depcheck incorrectly flags dependencies as unused

[yurishkuro]

What happened?

I want to see if all declared dependencies are actually used. We have yarn depcheck for this, but it incorrectly flags dependencies that are currently in use:

$ yarn depcheck
Unused devDependencies
* @types/rollup-plugin-visualizer
* @vitejs/plugin-legacy
* @vitejs/plugin-react
* rollup-plugin-visualizer
* vite-plugin-imp

Some of these plugins are in fact in use, they are declared in packages/jaeger-ui/vite.config.mts. Somehow we need to tell depcheck to ignore them. We already generate custom configs for depcheck in the scripts/run-depcheck.sh script, it probably needs to be extended somehow.

[prashantrewar]

hey @yurishkuro, I would like to work on this issue. Could you please guide me on this issue?

[yurishkuro]

start with yarn depcheck and go from there

[MeenuyD]

I am confused i have to change in scripts/run-depcheck.sh this or this packages/jaeger-ui/vite.config.mts

[yurishkuro]

@MeenuyD I don't know what the solution is. I described a problem that we want to solve, which is that depcheck incorrectly flags dependencies which are in fact being used.

[MeenuyD]

Ok

[tico88612]

@yurishkuro, Is the issue resolved? I checked the latest build and my PC, and there was no depcheck issue.

[yurishkuro]

$ yarn install --verbose  --frozen-lockfile

$ yarn depcheck
yarn run v1.22.19
$ ./scripts/run-depcheck.sh
Checking packages/jaeger-ui
    Unused devDependencies
    ⛔ @types/rollup-plugin-visualizer
    ⛔ @vitejs/plugin-legacy
    ⛔ @vitejs/plugin-react
    ⛔ rollup-plugin-visualizer
    ⛔ vite-plugin-imp
Checking packages/plexus
    No depcheck issue
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[tico88612]

Which depcheck version do you use?

❯ npm install -g [email protected]


added 17 packages, removed 17 packages, and changed 111 packages in 708ms

15 packages are looking for funding
  run `npm fund` for details
❯ yarn depcheck
yarn run v1.22.19
$ ./scripts/run-depcheck.sh
Checking packages/jaeger-ui
    Unused devDependencies
    ⛔ @types/rollup-plugin-visualizer
    ⛔ @vitejs/plugin-legacy
    ⛔ @vitejs/plugin-react
    ⛔ rollup-plugin-visualizer
    ⛔ vite-plugin-imp
Checking packages/plexus
    No depcheck issue
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
❯ npm install -g [email protected]


added 17 packages, removed 17 packages, and changed 111 packages in 676ms

15 packages are looking for funding
  run `npm fund` for details
❯ yarn depcheck
yarn run v1.22.19
$ ./scripts/run-depcheck.sh
Checking packages/jaeger-ui
    No depcheck issue
Checking packages/plexus
    No depcheck issue
✨  Done in 2.27s.

[yurishkuro]

I didn't realize we're running a globally installed depcheck - that's very bad, we need the builds to be reproducible, this is why we have yarn.lock.

jaeger-ui/.github/workflows/lint-build.yml

Line 30 in 8fe552a

yarn global add depcheck

depcheck itself should be added as a dependency.

[tico88612]

Agree. Do we lock depcheck to the latest version (1.4.7)?
Want to add in package.json or github/workflows/lint-build.yml?

[yurishkuro]

If we add to github/workflows/lint-build.yml then dependabot probably won't be able to upgrade it, so it's not ideal. It's better to keep all deps in package.json. Latest version is fine.