-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: depcheck incorrectly flags dependencies as unused #2132
Comments
hey @yurishkuro, I would like to work on this issue. Could you please guide me on this issue? |
start with |
I am confused i have to change in scripts/run-depcheck.sh this or this packages/jaeger-ui/vite.config.mts |
@MeenuyD I don't know what the solution is. I described a problem that we want to solve, which is that depcheck incorrectly flags dependencies which are in fact being used. |
Ok |
@yurishkuro, Is the issue resolved? I checked the latest build and my PC, and there was no depcheck issue. ![]() |
|
Which depcheck version do you use?
|
I didn't realize we're running a globally installed depcheck - that's very bad, we need the builds to be reproducible, this is why we have
|
Agree. Do we lock |
If we add to |
## Which problem is this PR solving? - Resolves #2132 ## Description of the changes - Add `depcheck 1.4.7` in `package.json` - Remove add global `depcheck` in CI test ## How was this change tested? - manual test ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: tico88612 <[email protected]>
What happened?
I want to see if all declared dependencies are actually used. We have
yarn depcheck
for this, but it incorrectly flags dependencies that are currently in use:Some of these plugins are in fact in use, they are declared in
packages/jaeger-ui/vite.config.mts
. Somehow we need to tell depcheck to ignore them. We already generate custom configs for depcheck in thescripts/run-depcheck.sh
script, it probably needs to be extended somehow.The text was updated successfully, but these errors were encountered: