-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[deps] Replace the use of moment.js with actively maintained library #1736
Labels
Comments
I did some research around this and two of the most popular date libraries are
I feel What do you say? I'm willing to work on this |
Can I work on this, if no one is working on this issue |
4 tasks
yurishkuro
pushed a commit
that referenced
this issue
Sep 22, 2023
## Which problem is this PR solving? - Resolves #1736 ## Description of the changes - I've removed `moment.js` and replaced it with `dayjs` packages - I've fixed all the failing tests - Tested all dates and time formatting ## How was this change tested? - All the test cases are passing - All the pages that got impacted were tested visually by me - Including the `Monitor` tab, `Span` and `Trace` view, `Search` page, all the charts, etc. The UI was checked between `jaeger-all-in-one` and changes of this commit ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Prathamesh Mutkure <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Moment.js is "a legacy project in maintenance mode", according to its official website https://momentjs.com/docs/#/-project-status/.
utils/date.tsx
The text was updated successfully, but these errors were encountered: