Skip to content
This repository has been archived by the owner on Oct 1, 2020. It is now read-only.

Fix compilation errors reported in Eclipse Mars #119

Merged
merged 1 commit into from
May 24, 2016

Conversation

Godin
Copy link
Member

@Godin Godin commented May 23, 2016

Prior to this change Eclipse 4.5.2 Mars (Build id: 20160218-0600) shows compilation errors in com.mountainminds.eclemma.core, com.mountainminds.eclemma.core.test and com.mountainminds.eclemma.debug.ui.compatibility.

Also

mvn clean verify \
    -Dimplicit-target \
    -Dplatform-repository-url=http:https://download.eclipse.org/releases/mars/

will stop at com.mountainminds.eclemma.core with inability to compile.

After this change the only remaining compilation error is in com.mountainminds.eclemma.debug.ui.compatibility and same Maven command will pass tests.

Result of opening of project in Eclipse 3.8 Juno is the same as before - only com.mountainminds.eclemma.debug.ui.compatibility contains compilation error - "cycle in the type hierarchy" what was done on purpose for compatibility with Eclipse < 3.8.

@Godin
Copy link
Member Author

Godin commented May 23, 2016

@marchof could you please review?

@marchof
Copy link
Member

marchof commented May 23, 2016

@Godin SupressWarning "unchecked" warning is not required at any of the places. It gives me a compiler warning with the 3.5 target. If I remove everything looks good.

Beside that:

  • Compiles in Eclipse with 3.5 target
  • Local Maven o.k.

@Godin
Copy link
Member Author

Godin commented May 24, 2016

@marchof for Mars it is exactly opposite - warning if no suppression 😆 but I removed "unchecked", will merge.

@marchof
Copy link
Member

marchof commented May 24, 2016

@Godin From my point the minimum supported version should be our default dev target. So code should compile for this version without warnings.

@Godin
Copy link
Member Author

Godin commented May 24, 2016

@marchof no pb.

A kind of off-topic - do you know how many users of EclEmma are on Eclipse 3.5 ? I guess this set is close to set of Java 5 users.

@Godin Godin merged commit 455050e into master May 24, 2016
@Godin Godin deleted the fix-compilation-errors branch May 24, 2016 07:08
@marchof
Copy link
Member

marchof commented May 24, 2016

@Godin Well, AFAIK there are plenty of users out there forced o work with historic RAD versions... We can rise the bar when we're at Eclipse.org.

@Godin Godin added this to the 2.3.4 milestone Aug 1, 2016
@jacoco jacoco locked and limited conversation to collaborators Jan 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants