Skip to content
This repository has been archived by the owner on Oct 1, 2020. It is now read-only.

Commit

Permalink
Upgrade maven-jarsigner-plugin plugin to 1.3
Browse files Browse the repository at this point in the history 
Upgrade maven-jarsigner-plugin plugin to version 1.3 and remove
workaround.
  • Loading branch information
@marchof
marchof committed Sep 1, 2015
1 parent fca1869 commit b2a1ba6
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions com.mountainminds.eclemma.build/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jarsigner-plugin</artifactId>
<version>1.2</version>
<version>1.3</version>
</plugin>
<!-- Mojo plugins -->
<plugin>
Expand Down Expand Up @@ -358,13 +358,8 @@
<goal>sign</goal>
</goals>
<configuration>
<arguments>
<!-- TODO Godin: there is no parameters for TSA in plugin, so we use workaround - see http:https://jira.codehaus.org/browse/MJARSIGNER-16 -->
<argument>-tsa</argument>
<argument>${jarsigner.tsa}</argument>
<argument>-tsacert</argument>
<argument>${jarsigner.tsacert}</argument>
</arguments>
<tsa>${jarsigner.tsa}</tsa>
<tsacert>${jarsigner.tsacert}</tsacert>

This comment has been minimized.

Sign in to view

Copy link
@Godin

Godin Sep 2, 2015

Member

@marchof "${jarsigner.tsa}" and "${jarsigner.tsacert}" are kind of useless, because they are defaults - see https://maven.apache.org/plugins/maven-jarsigner-plugin/sign-mojo.html#tsa
</configuration>
</execution>
</executions>
Expand Down

1 comment on commit b2a1ba6

@marchof
Copy link
Member Author

@marchof marchof commented on b2a1ba6 Sep 2, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Godin Thx, now removed. Should have created a PR for review :-/

Please sign in to comment.