Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically call member functions from static functions. #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xloem
Copy link

@xloem xloem commented May 11, 2020

This provides concise access to local data in implementations.

A slight refactor to improve ease of use a little.

This provides concise access to local data in implementations.
@paulwratt
Copy link

paulwratt commented Feb 21, 2022

A slight refactor to improve ease of use a little.

umm.. "slight" is an under statement to say the least - I cant see this being accepted (screeds of changes dont qualify as "slight").

At least seperate the Automatically call member functions from static functions from the slight re-factor.

(This is a common reason why most projects reject patches, because for some reason "newbie dev's" think its OK to perform "re-factor" as part of applying their intended patch - it will always get rejected.)

NOTE: it is not something you should be ashamed of, we have all done it at least once. Always adapt your coding style to the project. Submitting a (seperate) "formatting re-factor" is acceptable, but could also be a "touchy subject" for some projects, as this sort of "re-factor" is prone to an indivuals prefered style asthetic.

@xloem
Copy link
Author

xloem commented Feb 21, 2022

Paul, this project is only one class large and has only 33 commits. What are you talking about?

@xloem
Copy link
Author

xloem commented Feb 21, 2022

There is a static function for every member function. Automatically calling them means touching the entire implementation, and becomes a refactor.

Did you make this pull request comment with an automated system?

@xloem
Copy link
Author

xloem commented Feb 23, 2022

Apologies for my curt and rude reply. I was really tired. I am still curious if you use ai augmentation to make github comments.

It's hard to find Fuse++ implementations to add work to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants