-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rgb - hsl - rgb string - hsl string - hex rgb string
- stylesheets were getting updated with the previous color selection, not the current one - minor watch method cleanup for color.js and colorPicker.js - hslString.to fixed - space-saving cleanup for colorPicker.js and stylesheet.js
I've decided to remove tests for the time being, for the following reasons: - jsdom has a number of holes, primarily in its support for the stylesheet API, which makes it difficult to test `iro.stylesheet`. - Canvas rendering needs to be tested but it's difficult to do that programmatically. - Browser-based testing might be better
converting the color to hsl to draw the wheel makes very little difference visually
- color models also have a new `name` property which is used internally - build script has been updated to compress these property and method names, plus others that are only intended to be used internally
slider `type` props are now `sliderType`
(with the intention of making stylesheet.js *just* handle stylesheets not any features that are unique to colorPicker.js)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A complete rewrite of the library:
This has been a lot of work. I'm so glad that it's finally ready (: