Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 #4

Merged
merged 63 commits into from
Apr 25, 2017
Merged

V2 #4

merged 63 commits into from
Apr 25, 2017

Conversation

jaames
Copy link
Owner

@jaames jaames commented Apr 25, 2017 •
edited

A complete rewrite of the library:

  • The library is separated into modules, which makes it much easier to work on
  • Added webpack build script, with dev server and other neat things
  • Full API docs added
  • Color wheel rendering has been greatly improved
  • Stylesheet API got some under-the-hood improvements, and some extra methods thrown in
  • IE9 support was dropped in favor of file size -- V1 will be kept around for this reason
  • Docsite was dropped in favor of just using github. The fancy Vue & vue-router site sure looked cool, but it was terrible for SEO. I may use hexo in the future, though
  • Landing page has been completely redesigned so be more colorful
  • Added quick start guide to readme

This has been a lot of work. I'm so glad that it's finally ready (:

@jaames
remove+add files ready for rewrite
b95db40
@jaames
set up base + add build instructions to readme
a137ad9
@jaames
fix wepback dev server settings
ad7e9ea
@jaames
fix build script + update to webpack2
edce045
@jaames
make dev server use devmode settings
0d41336
@jaames
implement basic wheel ui
13cb160
@jaames
implement val slider
762d420
@jaames
fix marker drawing
a82483d
@jaames
minor optimisations
ae92ca4
@jaames
move ui modules
689620a
@jaames
set up colorPicker
1966af4
@jaames
complete input handling
fc2ef4b
@jaames
implement color object + ui feedback
955c529
@jaames
minor fixes
5738d18
@jaames
add various color models
24da8d4 
 - rgb
 - hsl
 - rgb string
 - hsl string
 - hex rgb string
@jaames
add basic color string identification
0145c0c
@jaames
minor improvements to color wheel drawing
e3589b9
@jaames
only redraw ui elements when needed
368cdd7
@jaames
better watch/unwatch functions and minor renaming
e85449f
@jaames
add stylesheet writer
c1d129a
@jaames
update stylesheet api
2191de1
@jaames
minor cleanup and bugfixes
5403828 
 - stylesheets were getting updated with the previous color selection,
not the current one

 - minor watch method cleanup for color.js and colorPicker.js

 - hslString.to fixed

 - space-saving cleanup for colorPicker.js and stylesheet.js
@jaames
start implementing tests
fbb89b1
@jaames
remove color model methods, let's just use props instead
ce5211f
@jaames
rearrange src directory structure
b893c15
@jaames
fix color model handling
a0fc97b
@jaames
fix a bug where safari wasn't keeping stylesheet rules up-to-date
79581b7
@jaames
remove tests (for now)
fc80a76 
I've decided to remove tests for the time being, for the following
reasons:

 - jsdom has a number of holes, primarily in its support for the
stylesheet API, which makes it difficult to test `iro.stylesheet`.
 - Canvas rendering needs to be tested but it's difficult to do that
programmatically.
 - Browser-based testing might be better
@jaames
very minor space-saving improvements
cee6b03
@jaames
clean up the rgb and hex color conversion stuff
ea3b2d0
jaames and others added 28 commits April 6, 2017 14:36
@jaames
add iroColor forceUpdate and register methods
d7e51e8
@jaames
remove the HSL dependency from wheel.js
9acfab0 
converting the color to hsl to draw the wheel makes very little
difference visually
@jaames
fix rgb -> hsv conversion
5e63c94
@jaames
color model improvements
100f7ea
@jaames
- color model to and from methods are now toHsv and fromHsv
56eacc9 
 - color models also have a new `name` property which is used internally
 - build script has been updated to compress these property and method
names, plus others that are only intended to be used internally
@jaames
rename set->update and make it take an iroColor object instead
783ec95
@jaames
implement color wheel change callback
acccbbe
@jaames
property mangling was breaking some DOM methods
3ae6eae
@jaames
add /assets
42b7830
@jaames
update package.json
c01aa9c
@jaames
create a new landing page
4e8df40
@jaames
add animated logo
7c7b4bb
@jaames
add a white bg to the animated logo
70e6bd7
@jaames
add social media meta tags to the landing page
b5ca430
@jaames
make colorPicker instances wait for the document to load
22fc1b9
@jaames
privatise "opts" prop and add "type" prop on all ui elements
3006b08 
slider `type` props are now `sliderType`
@jaames
move the css update code to colorPicker.js
fd95dda 
(with the intention of making stylesheet.js *just* handle stylesheets
not any features that are unique to colorPicker.js)
@jaames
capitalise color, colorWheel, and stylesheet module names
488c431
@jaames
start API docs
0472d15
@jaames
minor doc wording change
747b9b6
@jaames
add guide and introduction docpages
fbb154d
@jaames
some site fixes
8b1959c
@jaames
tiny fixes
ccc9e47
@jaames
add dist files
81ad685
@jaames
fix background not updating on demo site
d3bbce9
@jaames
update readme
ffb2f63
@jaames
small changes to doc + readme wording
cfa1d84
Merge branch 'master' into v2
ff47ba8
@jaames jaames merged commit a4e8623 into master Apr 25, 2017
@jaames jaames deleted the v2 branch April 25, 2017 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jaames