Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Object.definePropeties for color values, HiDPI support + small cleanup #1

Merged
merged 7 commits into from
Dec 15, 2016
Merged

Use Object.definePropeties for color values, HiDPI support + small cleanup #1

merged 7 commits into from
Dec 15, 2016

Conversation

jaames
Copy link
Owner

@jaames jaames commented Dec 15, 2016

Changes:

  • Remove IroExtendedColor constructor, and just drop the change-watching into IroColor.
  • Change the API slightly so that the color values can be accessed using properties in addition to methods (this is where Object.defineProperties was used).
  • Add support for HiDPI screens by modifying createCanvas() to scale the canvas based on the device pixel ratio.
  • Small cleanup and fixes

@jaames jaames merged commit e87be00 into master Dec 15, 2016
@jaames jaames deleted the obj-setter branch December 15, 2016 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jaames