Set the color by an HSL string

[obscuredetour]

Hey @jaames,

First of all let me say that iro.js is excellent! As you know I am using it in my pwa Color Deck.

I found a bug when setting the color using an HSL string. It causes iro.js to crash, with only a reload fixing it. This can be recreated in the iro.js demo (as shown below). Open the Console and type colorPicker.color.hslString = 'hsl(182, 35%, 65%)'.

I did notice that this extends to parsing an HSL string with the iro.Color.parseHslStr method as well. It returns 'parsed is null'. Perhaps, the two are related?

[jaames]

Hi @obscuredetour, thank you for the bug report!

I can confirm this is an issue on my end too. My guess is that the parseHslStr method isn't parsing the regex matches from the hsl string correctly (and hslString isn't working too since it uses this method internally). I'll take a look at it now.

Also thanks for the kind words! I'm happy to hear you chose iro.js for your app. Sorry about the awkward bug. :P

[jaames]

Ahah, seems like parseHslStr wasn't taking the right array values from the hsl string regex match. Just pushed a hotfix now -- hopefully that should solve it.

I think I'm also going to start implementing code tests to make sure something like that doesn't end up in the library again. Sorry for the trouble!

---

By the way, I'm currently working on the next major release of iro.js. You're welcome to join the v4 discussion thread if you have any feature suggestions or other feedback after using the library in your project. :)

[obscuredetour]

Thanks so much for the fix @jaames! That was fast 👍

I started testing v4 #30 in my project on a separate branch, but couldn't get many methods to work. So I'll wait for more of your awesome documentation. 😄 I am liking many of the features listed! I will add any I deem worthy. Thanks again!

[jaames]

Hey @obscuredetour! I finally got around to making the final changes on v4 and pushed it into production, the new documentation is live on https://iro.js.org now too :)