-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saturation gradient isn't being rendered correctly on Android #2
Comments
Now that's certainly a strange one. Thank you for the report! It looks like the hue ring is fine, but the radial gradient used to represent saturation isn't being drawn correctly, which pretty much narrows down the issue to these lines of code: https://github.com/jaames/iro.js/blob/master/src/iro.js#L557:L561. I've recreated the bug in a codepen here: I don't personally have an Android device to test with (hence why it managed slipped past me in the first place), however a friend was able to confirm that this is an issue on their device too. If I'm honest here, I'm pretty sure that this is an Android bug since I'm not be doing anything out of the ordinary as far as I can tell. I'll be sure to do more testing first, though. -- Oh, and yeah, as you noted this won't present any change with the picked color. That's calculated based on the position of the markers. (: |
I have only tested this in Android so far, but changing the "2" to "0" seems to fix the issue. |
And yea. Seems like createRadialGradient on Android struggles with radiuses between 0 and 15. Strange =/ |
That's... certainly odd. Oh well, at least we know what's causing it ¯\_(ツ)_/¯ I've committed a hotfix for the issue which implements the changes that you suggested, I hope it's resolved now Thanks again! |
Looks good. I'll close this issue then. Btw, it's good practice to close an issue when you think you've fixed it, and leave it to the other users to re-open it if there's more. Also, no problem. I've been looking for a lightweight colorpicker widget, and this looks perfect!(All the other nice looking ones require jQuery, bleh) |
I see, thanks for the tip! I hope you find it useful for your needs. By the way, I'm currently rewriting everything from the ground up over in the v2 branch, so please feel free to open up another issue if you have any feature requests or anything. It would be helpful to get some feedback. (: |
Using Chromium on Android (Also looks the same in FireFox)
Strangely enough, the picked color is correct(what color should be at that location on the wheel).
The text was updated successfully, but these errors were encountered: