-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt all Seq.crossJoin() methods to make use of SeqBuffer #333
Comments
I've noticed that this issue has not been addressed at all (it's not even labeled) so I hereby make a "ping" :) |
Thanks a lot for your ping. I'm sorry for the delays in these matters. Whether or not an alternative implementation for a variety of jOOλ API should be implemented is a rather time consuming task, time which I currently - very unfortunately - cannot allocate. This doesn't mean that jOOλ will not be improved, but it does mean that the cost / benefit ratio for complex changes like this one is currently not very good. There are lower hanging fruit which have higher chances of making it in the next releases. |
As a consequence, the 0.9.13 release has some SeqBuffer-eligible methods that are implemented using SeqBuffer and some that are not. I change the crossjoin method by implementing it by SeqBuffer() rather than toList()
This is related to #305, where the following
Seq
methods were declared eligible for reimplementation usingSeqBuffer
:crossSelfJoin()
(done in Added SeqBuffer<T> class as a replacement for some of Seq.toList() calls #305)inner(Self)Join()
(done in Added SeqBuffer<T> class as a replacement for some of Seq.toList() calls #305)leftOuter(Self)Join()
(done in Added SeqBuffer<T> class as a replacement for some of Seq.toList() calls #305)crossJoin()
(not done because it needs to be generated usingjOOQ-tools
)As a consequence, the 0.9.13 release has some
SeqBuffer
-eligible methods that are implemented usingSeqBuffer
and some that are not.Expected behavior and actual behavior:
Expected: All
Seq.crossJoin()
variants are implemented usingSeqBuffer
.Actual: All
Seq.crossJoin()
variants are implements usingSeq.toList()
.Versions:
The text was updated successfully, but these errors were encountered: