Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NormalViewState appstate and hook up for SceneViewer #398

Merged
merged 2 commits into from
Oct 23, 2022

Conversation

neph1
Copy link
Contributor

@neph1 neph1 commented Oct 13, 2022

This is using a temporary icon. I'll fix that once #385) is merged, rather than building this on top of the other branch.

image

Normal length could be debated. Currently it's 0.2 units.

Fixes #200

@neph1 neph1 marked this pull request as ready for review October 13, 2022 17:18
@neph1
Copy link
Contributor Author

neph1 commented Oct 14, 2022

Maybe it should have support for moving stuff around. Currently you'd have to toggle it off and on to see the changes.
Maybe also a refactoring of SceneApplication should be considered if we add more functionality, moving more to AppStates.

@neph1
Copy link
Contributor Author

neph1 commented Oct 15, 2022

Now it updates the debug transforms every update. Unnecessarily expensive? I considered doing some checks, like debug.transform != geometry.transform, but the checks themselves might be just as expensive.
I'd like to check for if a geometry is added or removed and mirror that in the debug view, but while I thought checking for removed ones would be simple, it didn't work as I had expected.

@neph1 neph1 merged commit 1e5f02e into jMonkeyEngine:master Oct 23, 2022
@neph1 neph1 deleted the 200_Add_normals_debug branch May 6, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Normals Debug
1 participant