-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VarType: format code #2199
VarType: format code #2199
Conversation
…at and Int VarType.Boolean: reorder the list of javaTypes in accordance with Float and Int - format code - update License year
fix import com.jme3.shader.bufferobject.BufferObject
Update VarType.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Combining formatting and functional changes in a single PR obscures the functional changes and makes them much harder to find and review. Please don't do this again.
On close inspection, it looks like the UniformBufferObject
and ShaderStorageBufferObject
constants have been combined into a new BufferObject
value. The rationale for this change is unclear.
I'm unsure whether this enum
's ordinal value is used anywhere---for instance if it's serialized as part of a Savable
. If it is, then I worry that change might break existing code.
Similarly, if existing code depends on the names of the changed constants, this might be a breaking change.
Thanks for your review @stephengold , I agree with you. I noticed this discrepancy in the order of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
VarType.Boolean
: reorder the list ofjavaTypes
in accordance withFloat
andInt