Skip to content

Commit

Permalink
Merge pull request #379 from egoldfarb/master
Browse files Browse the repository at this point in the history
Build files cleanup
  • Loading branch information
paween committed Jan 10, 2023
2 parents 243e3cb + 331403e commit fd75124
Show file tree
Hide file tree
Showing 12 changed files with 24 additions and 131 deletions.
5 changes: 1 addition & 4 deletions Package.swift
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ let package = Package(
.target(
name: "libPhoneNumber",
path: "libPhoneNumber",
exclude: ["GeneratePhoneNumberHeader.sh", "NBPhoneNumberMetadata.plist", "Info.plist"],
exclude: ["GeneratePhoneNumberHeader.sh", "Info.plist"],
publicHeadersPath: ".",
cSettings: [
.headerSearchPath("Internal")
Expand All @@ -27,10 +27,7 @@ let package = Package(
sources: [
"NBAsYouTypeFormatterTest.m",
"NBPhoneNumberParsingPerfTest.m",
"NBPhoneNumberUtil+ShortNumberTestHelper.h",
"NBPhoneNumberUtil+ShortNumberTestHelper.m",
"NBPhoneNumberUtilTest.m",
"NBShortNumberInfoTest.m"
]
)
]
Expand Down
11 changes: 4 additions & 7 deletions [email protected]
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ let package = Package(
name: "libPhoneNumber",
platforms: [
.macOS(.v10_10),
.iOS(.v9),
.tvOS(.v9),
.watchOS(.v2)
.iOS(.v11),
.tvOS(.v11),
.watchOS(.v4)
],
products: [
.library(
Expand All @@ -20,7 +20,7 @@ let package = Package(
.target(
name: "libPhoneNumber",
path: "libPhoneNumber",
exclude: ["GeneratePhoneNumberHeader.sh", "NBPhoneNumberMetadata.plist", "Info.plist"],
exclude: ["GeneratePhoneNumberHeader.sh", "Info.plist"],
publicHeadersPath: ".",
cSettings: [
.headerSearchPath("Internal")
Expand All @@ -36,10 +36,7 @@ let package = Package(
sources: [
"NBAsYouTypeFormatterTest.m",
"NBPhoneNumberParsingPerfTest.m",
"NBPhoneNumberUtil+ShortNumberTestHelper.h",
"NBPhoneNumberUtil+ShortNumberTestHelper.m",
"NBPhoneNumberUtilTest.m",
"NBShortNumberInfoTest.m"
]
)
]
Expand Down
11 changes: 4 additions & 7 deletions [email protected]
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ let package = Package(
platforms: [
.macOS(.v10_10),
.macCatalyst(.v13),
.iOS(.v9),
.tvOS(.v9),
.watchOS(.v2)
.iOS(.v11),
.tvOS(.v11),
.watchOS(.v4)
],
products: [
.library(
Expand All @@ -21,7 +21,7 @@ let package = Package(
.target(
name: "libPhoneNumber",
path: "libPhoneNumber",
exclude: ["GeneratePhoneNumberHeader.sh", "NBPhoneNumberMetadata.plist", "Info.plist"],
exclude: ["GeneratePhoneNumberHeader.sh", "Info.plist"],
publicHeadersPath: ".",
cSettings: [
.headerSearchPath("Internal")
Expand All @@ -37,10 +37,7 @@ let package = Package(
sources: [
"NBAsYouTypeFormatterTest.m",
"NBPhoneNumberParsingPerfTest.m",
"NBPhoneNumberUtil+ShortNumberTestHelper.h",
"NBPhoneNumberUtil+ShortNumberTestHelper.m",
"NBPhoneNumberUtilTest.m",
"NBShortNumberInfoTest.m"
]
)
]
Expand Down
4 changes: 2 additions & 2 deletions libPhoneNumber-iOS.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ DESC
s.source = { :git => "https://github.com/iziz/libPhoneNumber-iOS.git", :tag => s.version.to_s }
s.libraries = 'z'
s.ios.framework = 'CoreTelephony'
s.ios.deployment_target = "10.0"
s.ios.deployment_target = "11.0"
s.osx.deployment_target = "10.9"
s.watchos.deployment_target = "4.0"
s.tvos.deployment_target = "10.0"
s.tvos.deployment_target = "11.0"
s.requires_arc = true
s.private_header_files = 'libPhoneNumber/NBGeneratedPhoneNumberMetaData.h'
s.source_files = 'libPhoneNumber/NBPhoneNumberDefines.{h,m}', 'libPhoneNumber/NBPhoneNumber.{h,m}', 'libPhoneNumber/NBNumberFormat.{h,m}', 'libPhoneNumber/NBPhoneNumberDesc.{h,m}', 'libPhoneNumber/NBPhoneMetaData.{h,m}', 'libPhoneNumber/NBPhoneNumberUtil.{h,m}', 'libPhoneNumber/NBMetadataHelper.{h,m}', 'libPhoneNumber/NBAsYouTypeFormatter.{h,m}', 'libPhoneNumber/NSArray+NBAdditions.{h,m}', 'libPhoneNumber/NBGeneratedPhoneNumberMetaData.h', 'libPhoneNumber/Internal/NBRegExMatcher.{h,m}', 'libPhoneNumber/Internal/NBRegularExpressionCache.{h,m}'
Expand Down
31 changes: 8 additions & 23 deletions libPhoneNumber.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,6 @@
A81D6A281BECC43A00F68F34 /* NBPhoneNumberDefines.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; lineEnding = 0; path = NBPhoneNumberDefines.m; sourceTree = "<group>"; };
FD12C2681A87401B00B53856 /* NBMetadataHelper.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NBMetadataHelper.h; sourceTree = "<group>"; };
FD12C2691A87401B00B53856 /* NBMetadataHelper.m */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.objc; path = NBMetadataHelper.m; sourceTree = "<group>"; };
FD379E291A8AE5150015C184 /* NBPhoneNumberMetadata.plist */ = {isa = PBXFileReference; lastKnownFileType = file.bplist; path = NBPhoneNumberMetadata.plist; sourceTree = "<group>"; };
FD7A0620167715A0004BBEB6 /* UIKit.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = UIKit.framework; path = System/Library/Frameworks/UIKit.framework; sourceTree = SDKROOT; };
FD7A0622167715A0004BBEB6 /* Foundation.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = Foundation.framework; path = System/Library/Frameworks/Foundation.framework; sourceTree = SDKROOT; };
FD7A0624167715A0004BBEB6 /* CoreGraphics.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = CoreGraphics.framework; path = System/Library/Frameworks/CoreGraphics.framework; sourceTree = SDKROOT; };
Expand Down Expand Up @@ -460,7 +459,6 @@
FD12C2681A87401B00B53856 /* NBMetadataHelper.h */,
FD12C2691A87401B00B53856 /* NBMetadataHelper.m */,
8BB73AA71E7C9C6700B0691B /* NBGeneratedPhoneNumberMetaData.h */,
FD379E291A8AE5150015C184 /* NBPhoneNumberMetadata.plist */,
);
name = Metadata;
sourceTree = "<group>";
Expand Down Expand Up @@ -862,7 +860,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
INFOPLIST_FILE = libPhoneNumberGeocoding/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 10.1;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down Expand Up @@ -908,7 +906,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
INFOPLIST_FILE = libPhoneNumberGeocoding/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 10.1;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down Expand Up @@ -1010,15 +1008,10 @@
DEBUG_INFORMATION_FORMAT = dwarf;
GCC_GENERATE_TEST_COVERAGE_FILES = NO;
GCC_INSTRUMENT_PROGRAM_FLOW_ARCS = NO;
GCC_PREPROCESSOR_DEFINITIONS = (
"DEBUG=1",
"TESTING=1",
SHORT_NUMBER_SUPPORT,
);
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
INFOPLIST_FILE = libPhoneNumberTests/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 10.1;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down Expand Up @@ -1046,14 +1039,10 @@
ENABLE_NS_ASSERTIONS = NO;
GCC_GENERATE_TEST_COVERAGE_FILES = NO;
GCC_INSTRUMENT_PROGRAM_FLOW_ARCS = NO;
GCC_PREPROCESSOR_DEFINITIONS = (
"TESTING=1",
SHORT_NUMBER_SUPPORT,
);
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
INFOPLIST_FILE = libPhoneNumberTests/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 10.1;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down Expand Up @@ -1086,17 +1075,13 @@
DYLIB_INSTALL_NAME_BASE = "@rpath";
ENABLE_STRICT_OBJC_MSGSEND = YES;
GCC_NO_COMMON_BLOCKS = YES;
GCC_PREPROCESSOR_DEFINITIONS = (
"DEBUG=1",
"$(inherited)",
);
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
INFOPLIST_FILE = "libPhoneNumber-iOS/Info.plist";
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down Expand Up @@ -1147,7 +1132,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
INFOPLIST_FILE = "libPhoneNumber-iOS/Info.plist";
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 10.0;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down Expand Up @@ -1193,7 +1178,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
INFOPLIST_FILE = libPhoneNumberShortNumber/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 10.1;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down Expand Up @@ -1238,7 +1223,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
INFOPLIST_FILE = libPhoneNumberShortNumber/Info.plist;
INSTALL_PATH = "$(LOCAL_LIBRARY_DIR)/Frameworks";
IPHONEOS_DEPLOYMENT_TARGET = 10.1;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
"@executable_path/Frameworks",
Expand Down
Binary file removed libPhoneNumber/NBPhoneNumberMetadata.plist
Binary file not shown.
4 changes: 2 additions & 2 deletions libPhoneNumberGeocoding.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ DESC
s.authors = { "rastaarh" => "[email protected]", "paween" => "[email protected]", "aalexli" => "[email protected]" }
s.source = { :git => "https://github.com/iziz/libPhoneNumber-iOS.git", :tag => s.version.to_s }
s.libraries = 'z'
s.ios.deployment_target = "10.0"
s.ios.deployment_target = "11.0"
s.osx.deployment_target = "10.9"
s.watchos.deployment_target = "4.0"
s.tvos.deployment_target = "10.0"
s.tvos.deployment_target = "11.0"
s.requires_arc = true
s.resources = "libPhoneNumberGeocoding/Metadata/*.bundle"
s.private_header_files = 'libPhoneNumber/NBGeneratedPhoneNumberMetaData.h'
Expand Down
4 changes: 2 additions & 2 deletions libPhoneNumberShortNumber.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@ DESC
s.authors = { "rastaarh" => "[email protected]", "paween" => "[email protected]"}
s.source = { :git => "https://github.com/iziz/libPhoneNumber-iOS.git", :tag => s.version.to_s }
s.libraries = 'z'
s.ios.deployment_target = "10.0"
s.ios.deployment_target = "11.0"
s.osx.deployment_target = "10.9"
s.watchos.deployment_target = "4.0"
s.tvos.deployment_target = "10.0"
s.tvos.deployment_target = "11.0"
s.requires_arc = true
s.private_header_files = 'libPhoneNumberShortNumber/NBGeneratedShortNumberMetadata.h'
s.dependency 'libPhoneNumber-iOS'
Expand Down
1 change: 0 additions & 1 deletion libPhoneNumberShortNumberTests/NBShortNumberInfoTest.m
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
#import "NBPhoneNumberDesc.h"
#import "NBShortNumberUtil.h"

#import "NBGeneratedShortNumberMetadata.h"
#import "NBShortNumberMetadataHelper.h"
#import "NBShortNumberTestHelper.h"

Expand Down
2 changes: 1 addition & 1 deletion libPhoneNumberShortNumberTests/NBShortNumberTestHelper.m
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
// Copyright © 2017 Google LLC. All rights reserved.
//
#import "NBShortNumberTestHelper.h"
#import "NBPhoneMetadata.h"
#import "NBPhoneMetaData.h"
#import "NBPhoneNumberDesc.h"
#import "NBShortNumberMetadataHelper.h"
#import "NBShortNumberUtil.h"
Expand Down
29 changes: 0 additions & 29 deletions libPhoneNumberTests/NBPhoneNumberUtil+ShortNumberTest.h

This file was deleted.

53 changes: 0 additions & 53 deletions libPhoneNumberTests/NBPhoneNumberUtil+ShortNumberTest.m

This file was deleted.

0 comments on commit fd75124

Please sign in to comment.