Add option to allow disabling root password check for halt, reboot and suspend. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krayon
reviewed
Jul 26, 2022
| @@ -421,7 +421,7 @@ void App::Run() | |||
| } | |||
|
|
|||
| #ifdef USE_PAM | |||
| bool App::AuthenticateUser(bool focuspass) | |||
| bool App::AuthenticateUser(bool focuspass, bool hrsauth) | |||
There was a problem hiding this comment.
You need to add the , bool hrsauth passing to the non-PAM version of the function too at #448
krayon
reviewed
Jul 26, 2022
Comment on lines
+476
to
+479
| if(hrsauth) | ||
| pw = getpwnam("root"); | ||
| else | ||
| return true |
There was a problem hiding this comment.
Suggested change
| if(hrsauth) | |
| pw = getpwnam("root"); | |
| else | |
| return true | |
| if(!hrsauth) return true; | |
| pw = getpwnam("root"); |
There was a problem hiding this comment.
I don't think this change is quite right. The function should return true in the "if (!focuspass)" clause just above, where the "This is simply fake!" comment is. I believe that comment is misleading - it's actually the mechanism by which the Exit and Console actions are accepted without requesting a password.
|
Hi, I proposed this a lot of time ago, but have not been using slim for years now. So you can consider this PR abandoned by me. But feel free to work on it and grab these patches if they are useful to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more an hack than a real implementation, but I'd like some feedback and maybe this can be made in something that can be included in the official sources.
Thanks!